Vim is now very popular and has spawned numerous successors. But its key feature, modes, is not obviously-beneficial, to the point that if Bill Joy didn’t make vi (vim’s direct predecessor) fifty years ago I don’t think we’d have any modal editors today.